-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accept null dlhandle and support custom dlopen flags #35
Conversation
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Codecov Report
@@ Coverage Diff @@
## ign-plugin1 #35 +/- ##
===============================================
- Coverage 99.82% 98.64% -1.19%
===============================================
Files 15 15
Lines 584 592 +8
===============================================
+ Hits 583 584 +1
- Misses 1 8 +7
Continue to review full report at Codecov.
|
I made a cimment about this here gazebosim/gz-sensors#90 (comment) |
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
@ahcorde , I think the current version of this PR addresses those test failures. This PR adds support for
Let me know what you think. |
Signed-off-by: Louise Poubel <[email protected]>
I started writing some tests using I'm afraid that we get this in, start using |
Removing beta label, we won't have time to wrap this up before code freeze. Let's retarget at Ignition-F. |
Let's table this idea for now, tweaking the flags is probably not the best way to go about this. |
After digging through #30,
I was able to getUpdate: this PR also allows changing setting to global.ign-sensors
to work with only this change, without touching the local / global variables. It seems to me that this change is backwards compatible, because it only tries the nullptr after trying the usual method first.We know no previous use cases were getting a null handle because we haven't run into that assert. So I think this is safe to go into
ign-plugin1
.Unfortunately, I have no idea what leads us into this situation, so I'm not able to write a test case for it 😕
Let me know what you think, @ahcorde .
Here's the
ign-sensors
PR that uses this: gazebosim/gz-sensors#90